29/05/2018 18:20, Gavin Hu: > > > -----Original Message----- > > From: Bruce Richardson <bruce.richard...@intel.com> > > Sent: Tuesday, May 29, 2018 11:00 PM > > To: Thomas Monjalon <tho...@monjalon.net> > > Cc: Gavin Hu <gavin...@arm.com>; dev@dpdk.org > > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2 1/2] mk: fix cross build > > errors > > > > On Tue, May 29, 2018 at 04:45:55PM +0200, Thomas Monjalon wrote: > > > 28/05/2018 15:24, Bruce Richardson: > > > > Would a simpler solution for this not be to put "-Wno-implicit- > > fallthrough" > > > > for pmdinfogen? GCC will not give a warning for an unrecognised "-Wno" > > > > flag when compiling, unless there are other errors. This means we > > > > can just use the flag without bothering with version checks. > > > > > > No, it does not work. > > > I have this error with clang 5.0.1: > > > error: unknown warning option '-Wno-format-truncation' > > > > > Yes, you still need to check for GCC to use the flag, just not for a > > specific > > version of GCC. > > > > /Bruce > Hi Thomas, did you meet this clang error when you applied my patch(which > version?) or your own one? > @Bruce and Thomas, Could you review my v5 patch? Thanks!
I've already replied to your v5. The error is seen with your v5.
