> -----Original Message----- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, May 22, 2018 1:33 PM > To: Liu, Changpeng <changpeng....@intel.com> > Cc: dev@dpdk.org; Maxime Coquelin <maxime.coque...@redhat.com> > Subject: Re: [dpdk-dev] [PATCH 1/2] examples/vhost_scsi: add virtio-1.0 > feature > bit support > > 22/05/2018 19:51, Thomas Monjalon: > > 18/05/2018 14:35, Maxime Coquelin: > > > > > > On 05/18/2018 01:32 AM, Changpeng Liu wrote: > > > > Signed-off-by: Changpeng Liu <changpeng....@intel.com> > > > > --- > > > > examples/vhost_scsi/vhost_scsi.c | 7 ++++--- > > > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > > > Reviewed-by: Maxime Coquelin <maxime.coque...@redhat.com> > > > > Patch 1 applied alone, thanks > > After compilation tests, the patch is not accepted in 18.05, > because VIRTIO_F_VERSION_1 seems not defined on some distributions, > despite the fallback implemented.
What a mess for vhost library. :). lib/librte_vhost/vhost.h has the definition VIRTIO_F_VERSION_1 for some older kernel, but didn't include in the public API header <rte_vhost.h>, looks like we should move this definition to rte_vhost.h for some old kernels. >
