18/05/2018 01:32, Changpeng Liu: > Signed-off-by: Changpeng Liu <changpeng....@intel.com>
Missing explanations. > - strlcpy((char *)vpage->params, bdev->name, > - sizeof(vpage->params)); > + vhost_strcpy_pad((char *)vpage->params, bdev->name, > + sizeof(vpage->params), ' '); Why do you think vhost_strcpy_pad is safer than strlcpy? > - strncpy(bdev->name, bdev_name, sizeof(bdev->name)); > - strncpy(bdev->product_name, bdev_serial, sizeof(bdev->product_name)); > + snprintf(bdev->name, sizeof(bdev->name), "%s", bdev_name); > + snprintf(bdev->product_name, sizeof(bdev->product_name), > + "%s", bdev_serial); You should use strlcpy.
