Hi Akhil, > -----Original Message----- > From: Akhil Goyal <akhil.go...@nxp.com> > Sent: Monday, April 16, 2018 8:18 PM > To: Gujjar, Abhinandan S <abhinandan.guj...@intel.com>; > jerin.ja...@caviumnetworks.com; hemant.agra...@nxp.com; > dev@dpdk.org > Cc: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com>; Doherty, > Declan <declan.dohe...@intel.com>; Vangati, Narender > <narender.vang...@intel.com>; Rao, Nikhil <nikhil....@intel.com> > Subject: Re: [dpdk-dev, v1, 5/5] doc: add event crypto adapter > documentation > > Hi Abhinandan, > > On 4/4/2018 12:27 PM, Abhinandan Gujjar wrote: > > Add entries in the programmer's guide, API index, maintainer's file > > and release notes for the event crypto adapter. > > > > Signed-off-by: Abhinandan Gujjar <abhinandan.guj...@intel.com> > > --- > > [.snip.] > > + > > +Set event request/response information > > +-------------------------------------- > > + > > +In the ENQ_DEQ mode, the application needs to specify the cryptodev > > +ID and queue pair ID (request information) in addition to the event > > +information (response information) needed to enqueue an event after > > +the crypto operation has completed. The request and response > > +information are specified in the ``struct rte_crypto_op`` private > > +data or session's private data. > > + > > +In the DEQ mode, the application is required to provide only the > > +response information. > > + > > +The SW adapter or HW PMD uses ``rte_crypto_op::sess_type`` to decide > > +whether request/response data is located in the crypto session/ > > +crypto security session or at an offset in the ``struct rte_crypto_op``. > > +The ``rte_crypto_op::private_data_offset`` is used to locate the > > +request/ response in the ``rte_crypto_op``. > > + > > +For crypto session, ``rte_cryptodev_sym_session_set_private_data()`` > > +API will be used to set request/response data. The same data will be > > +obtained by ``rte_cryptodev_sym_session_get_private_data()`` API. > > + > > +For security session, ``rte_security_session_set_private_data()`` API > > +will be used to set request/response data. The same data will be > > +obtained by ``rte_security_session_get_private_data()`` API. > > I think you have missed this security API in your patches. > Also I don't think this methodology for adding the private data in session > will > work in case of security sessions. As we have only one API for > creating/configuring the security session. However, we can add a parameter > in the rte_security_session_create(). Since this API is still experimental, we > can change the parameters. What Say?
Sorry for the delayed response. If you feel, changing the create API is the right approach please go ahead. We don't have strong opinion on this. Regards Abhinandan > > > -Akhil
