>-----Original Message----- >From: Trahe, Fiona [mailto:fiona.tr...@intel.com] >Sent: 08 May 2018 20:14 >To: Verma, Shally <shally.ve...@cavium.com>; De Lara Guarch, Pablo ><pablo.de.lara.gua...@intel.com> >Cc: Doherty, Declan <declan.dohe...@intel.com>; Athreya, Narayana Prasad ><narayanaprasad.athr...@cavium.com>; Sahu, Sunila ><sunila.s...@cavium.com>; Gupta, Ashish <ashish.gu...@cavium.com>; >dev@dpdk.org; Sahu, Sunila <sunila.s...@cavium.com>; >Gupta, Ashish <ashish.gu...@cavium.com> >Subject: RE: [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev > >Hi Shally, > > >> -----Original Message----- >> From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] >> Sent: Thursday, April 5, 2018 12:25 PM >> To: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com> >> Cc: Doherty, Declan <declan.dohe...@intel.com>; Trahe, Fiona >> <fiona.tr...@intel.com>; >> pathr...@caviumnetworks.com; ss...@caviumnetworks.com; >> agu...@caviumnetworks.com; >> dev@dpdk.org; Sunila Sahu <sunila.s...@caviumnetworks.com>; Ashish Gupta >> <ashish.gu...@caviumnetworks.com> >> Subject: [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev >> >> struct rte_cryptodev_sym_session * >> rte_cryptodev_sym_session_create(struct rte_mempool *mp) >> { >> struct rte_cryptodev_sym_session *sess; >> >> /* Allocate a session structure from the session pool */ >> - if (rte_mempool_get(mp, (void **)&sess)) { >> + if (rte_mempool_get(mp, (void *)&sess)) { >[Fiona] Are you introducing a bug here? >The fn expects a void ** [Shally] Ya. My bad. Missed it.
>Also this will need rebasing - the latest code has an extra byte.
