On Tue, Oct 28, 2014 at 04:33:18PM +0100, Thomas Monjalon wrote: > 2014-10-28 14:51, Sergio Gonzalez Monroy: > > On Tue, Oct 28, 2014 at 11:45:28AM +0000, De Lara Guarch, Pablo wrote: > > > > Building combined shared libs fails if we set EXTRA_CFLAGS=-O0. > > > > > > > > /usr/bin/ld: test: hidden symbol `mknod' in > > > > /usr/lib64/libc_nonshared.a(mknod.oS) is referenced by DSO > > > > /usr/bin/ld: final link failed: Bad value > > > > collect2: error: ld returned 1 exit status > > > > > > > > Fix: link combined shared lib using CC if LINK_USING_CC is enabled. > > > > > > > > Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy at > > > > intel.com> > > > > > > Plus, should we include compilation errors in commits? > > > They are quite useful to identify the problem that > > > the patch is solving, but not sure if this should be shown in the git log. > > > > > I was wondering about it myself. I think it is useful info but maybe t is > > more > > appropiate to have it as a comment or cover letter just on the mailing list. > > I don't have a strong preference for including it, maybe someone else has an > > opinion about this? > > We are not limited in characters in the commit log. So every useful > information > (like error output) is more than welcome. > The only thing which needs to be shorter than a twitter post, is the title. > Because short and clear titles help to scroll commits. > > That said, don't put things which have no interest at all. Here I'd put only > this: > ld: test: hidden symbol `mknod' in > /usr/lib64/libc_nonshared.a(mknod.oS) is referenced by DSO > Thanks for the tips!
I'll send a v2 with changes. Sergio > -- > Thomas
