On Tue, Oct 28, 2014 at 11:45:28AM +0000, De Lara Guarch, Pablo wrote: > > > > -----Original Message----- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Sergio Gonzalez > > Monroy > > Sent: Thursday, October 23, 2014 4:36 PM > > To: dev at dpdk.org > > Subject: [dpdk-dev] [PATCH] mk: link combined lib using CC > > > > Building combined shared libs fails if we set EXTRA_CFLAGS=-O0. > > > > /usr/bin/ld: test: hidden symbol `mknod' in > > /usr/lib64/libc_nonshared.a(mknod.oS) is referenced by DSO > > /usr/bin/ld: final link failed: Bad value > > collect2: error: ld returned 1 exit status > > > > Fix: link combined shared lib using CC if LINK_USING_CC is enabled. > > > > Signed-off-by: Sergio Gonzalez Monroy > > <sergio.gonzalez.monroy at intel.com> > > Plus, should we include compilation errors in commits? > They are quite useful to identify the problem that > the patch is solving, but not sure if this should be shown in the git log. > I was wondering about it myself. I think it is useful info but maybe t is more appropiate to have it as a comment or cover letter just on the mailing list. I don't have a strong preference for including it, maybe someone else has an opinion about this?
Thanks, Sergio > Thanks, > Pablo >
