On Mon, 13 Oct 2014 18:42:18 +0000 Yong Wang <yongwang at vmware.com> wrote:
> Are you referring to the patch as a whole or your comment is about the reset > of vlan_tci on the "else" (no vlan tags stripped) path? I am not sure I get > your comments here. This patch simply fixes a bug on the rx vlan stripping > path (where valid vlan_tci stripped is overwritten unconditionally later on > the rx path in the original vmxnet3 pmd driver). All the other pmd drivers > are doing the same thing in terms of translating descriptor status to > rte_mbuf flags for vlan stripping. I was thinking that there are many fields in a pktmbuf and rather than individually setting them (like tci). The code should call the common rte_pktmbuf_reset before setting the fields. That way when someone adds a field to mbuf they don't have to chasing through every driver that does it's own initialization.
