Are you referring to the patch as a whole or your comment is about the reset of vlan_tci on the "else" (no vlan tags stripped) path? I am not sure I get your comments here. This patch simply fixes a bug on the rx vlan stripping path (where valid vlan_tci stripped is overwritten unconditionally later on the rx path in the original vmxnet3 pmd driver). All the other pmd drivers are doing the same thing in terms of translating descriptor status to rte_mbuf flags for vlan stripping. ________________________________________ From: Stephen Hemminger <step...@networkplumber.org> Sent: Monday, October 13, 2014 2:31 AM To: Yong Wang Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/5] vmxnet3: Fix VLAN Rx stripping
On Sun, 12 Oct 2014 23:23:05 -0700 Yong Wang <yongwang at vmware.com> wrote: > Shouldn't reset vlan_tci to 0 if a valid VLAN tag is stripped. > > Signed-off-by: Yong Wang <yongwang at vmware.com> Since vlan_tci is initialized to zero by rte_pktmbuf layer, the driver shouldn't be messing with it.
