2014-10-21 14:14, Liu, Jijiang: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2014-10-21 16:46, Jijiang Liu: > > > - uint16_t reserved2; /**< Unused field. Required for padding */ > > > + > > > + /** > > > + * Packet type, which is used to indicate ordinary L2 packet format and > > > + * also tunneled packet format such as IP in IP, IP in GRE, MAC in GRE > > > + * and MAC in UDP. > > > + */ > > > + uint16_t packet_type; > > > > Why not name it "l2_type"? > > In datasheet, this term is called packet type(s).
That's exactly the point I want you really understand! This is a field in generic mbuf structure, so your datasheet has no value here. > Personally , I think packet type is more clear what meaning of this field is > . ^_^ You cannot add an API field without knowing what will be its generic meaning. Please think about it and describe its scope. Thanks -- Thomas
