2014-10-17 05:58, Liu, Jijiang: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2014-10-11 13:55, Jijiang Liu: > > > # > > > +# Compile tunneling UDP port support > > > +# > > > +CONFIG_RTE_LIBRTE_TUNNEL_UDP_PORT=4789 > > > + > > > +# > > > > 1) this option is not to "Compile tunneling UDP port support" > Change the comment as "tunneling UDP default port configuration" > > 2) why is it a compile time option? should it be an API parameter or a > > runtime option? > > In terms of VxLAN, "IANA has assigned the value 4789 for the VXLAN UDP port, > and this value SHOULD be used by default as the destination UDP port. > Some early implementations of VXLAN have used other values for the > destination port. To enable interoperability with these implementations, > the destination port SHOULD be configurable."
Please, do not consider a compile time option like "configurable". There are some cases where the user cannot or don't want to rebuild DPDK. > I have provided a API to configure UDP port. OK, good. > But a default UDP port number is needed where PF startup if current mode is > VxLAN mode. Sorry, I don't understand this part. Why are you adding a default tunnel when initializing? Is it not enough to allow adding new tunnels with custom port? -- Thomas
