2014-09-23 21:14, Chen Jing D: > + PMD_DRV_LOG(ERR, "VMDQ not %s, can't set mac to pool %u\n", > + pf->flags | I40E_FLAG_VMDQ ? "configured" : "enabled", > + pool); [...] > - if (ret != I40E_SUCCESS) { > - PMD_DRV_LOG(ERR, "Failed to write mac address"); > + if (pool > pf->nb_cfg_vmdq_vsi) { > + PMD_DRV_LOG(ERR, "Pool number %u invalid. Max pool is %u\n", > + pool, pf->nb_cfg_vmdq_vsi); [...] > - PMD_DRV_LOG(ERR, "Failed to add MACVLAN filter"); > + PMD_DRV_LOG(ERR, "Failed to add MACVLAN filter\n"); [...] > + PMD_DRV_LOG(ERR, "Failed to remove MACVLAN > filter\n");
I'm pretty sure you rebased this patch and solved the conflicts without updating your patch accordingly. Indeed carriage returns have been removed from logs recently. Hint: rebase conflicts are really often meaningful ;) -- Thomas