On Wed, Oct 08, 2014 at 10:43:31AM +0200, David Marchand wrote: > Following "options parsing" patchset (commit d7cb626f and 489a9d6c), core > detection is not working correctly on bsd. > > ./x86_64-native-bsdapp-gcc/app/test -c f -n 4 -- -i > [...] > EAL: lcore 0 unavailable > EAL: invalid coremask > > Align bsd to linux: > - commit f563a372 "eal: fix recording of detected/enabled logical cores" > - commit 4f04db8b "eal: check coremask against detected lcores" > > Reported-by: Zhan, Zhaochen <zhaochen.zhan at intel.com> > Signed-off-by: David Marchand <david.marchand at 6wind.com>
Acked-by: Neil Horman <nhorman at tuxdriver.com> Though, that said, why are these files diverged in the first place? At least as far as eal_lcore.c and eal.c are concerned the only differences appear to be cases of one file being updated and not the other. It seems that, rather than doing a patch like this to bring bsd up to date with linux, we should just de-dup the files, put them in a common location and handle any real behavioral differences with macros/ifdefs. Is there a reason for separating them? Neil
