> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, May 14, 2014 11:34 AM > To: Richardson, Bruce > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] mk: allow updates to build config on make > install > > Hi Bruce > > 2014-05-14 11:22, Bruce Richardson: > > There was an issue with rebuilding the code following a change to one > > of the config files inside the "config" directory. If one did a "make > > install T=<target>" and then made a modification to the > > defconfig_<target> file (or applied a patch which modified that file) > > a subsequent re-run of the make install command would not rebuild the > > .config file leading to either build failures or an incorrect build. > > This change fixes that issue. > > Your patch is reverting this one: > mk: in install rule, don't overwrite .config if it already exists > http://dpdk.org/browse/dpdk/commit/?id=1c858a7dfebd4e4092eb55 > As stated in the commit log, > "This allows the user to prepare a configuration with make config > before using make install." > > So your patch is introducing a regression. > > I think you are describing something which is not a bug. > If you make a modification to the configuration template, you must explicitly > call "make config". > Ok, thanks for that Thomas. However, I still think we have a bug here, or at least we need some discussion on the correct behaviour we expect to have. From my point of view, the new behaviour is problematic, as every time I apply a patch or do a pull, I need to do a "make uninstall" or "make config" before doing "make install" just in case something has changed in the defconfig file, even if I have changed nothing on my end. This is not expected behaviour: if a change is made to the repository, doing a rebuild should rebuild everything which needs to be built to take account of that change.
Regards, /Bruce
