Yes, good point. I'll try and redraft a v3 of the patch (thanks Thomas for doing a V2), with that in it. I also think if we keep everything in the build dir we should not the rm afterwards. [In my previous tests when doing V1 patch, I found that deleting the directory each time seemed to slow things down for the next run. I'll test if that is still the case when doing V3]
> -----Original Message----- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier MATZ > Sent: Tuesday, June 10, 2014 9:03 AM > To: Thomas Monjalon; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] mk: allow updates to build config on make > install > > Hi Thomas, > > On 06/10/2014 03:51 PM, Thomas Monjalon wrote: > > + if [ -f $(BUILD_DIR)/$*/.config.orig ] ; then \ > > + tmp_build=/tmp/dpdk-$*-$$$$; \ > > + $(MAKE) config T=$* O=$$(tmp_build); \ > > + if ! cmp -s $(BUILD_DIR)/$*/.config.orig > $$(tmp_build)/.config ; then \ > > + echo "Conflict: local config and template > config have both changed"; \ > > + exit 1; \ > > I missed it the first time, but what do you think about using > $(BUILD_DIR)/$*/.config.tmp instead of /tmp/dpdk-$*-$$ ? > I think using /tmp should be avoided when possible as it is a > shared folder. > > Regards, > Olivier
