Hi, On 12/18/2014 09:40 AM, Olivier MATZ wrote: > Hi Neil, > > On 12/17/2014 06:03 PM, Neil Horman wrote: >> Back in: >> >> commit aaa662e75c23c61a1d79bd4d1f9f35b4967c39db >> Author: Alan Carew <alan.carew at intel.com> >> Date: Fri Dec 5 15:19:07 2014 +0100 >> >> cmdline: fix overflow on bsd >> >> The author failed to fixup a call to cmdline_parse_etheraddr in xenvirt. >> This >> patch makes the needed correction to avoid a build break >> >> Signed-off-by: Neil Horman <nhorman at tuxdriver.com> > > Sorry, I missed that one, thank you for fixing it. > > Acked-by: Olivier Matz <olivier.matz at 6wind.com>
Hmm, I agree with Thomas that sizeof(dict->addr) would be better as it explicitly uses the length of the field we write into. Regards, Olivier
