Hi Neil,
2014-12-17 12:03, Neil Horman:
> Back in:
>
> commit aaa662e75c23c61a1d79bd4d1f9f35b4967c39db
> Author: Alan Carew <alan.carew at intel.com>
> Date: Fri Dec 5 15:19:07 2014 +0100
>
> cmdline: fix overflow on bsd
>
> The author failed to fixup a call to cmdline_parse_etheraddr in xenvirt. This
> patch makes the needed correction to avoid a build break
>
> Signed-off-by: Neil Horman <nhorman at tuxdriver.com>
> CC: Thomas Monjalon <thomas.monjalon at 6wind.com>
What is the meaning of CC here?
> --- a/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c
> +++ b/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c
> @@ -586,8 +586,9 @@ rte_eth_xenvirt_parse_args(struct xenvirt_dict *dict,
> if (!strncmp(pair[0], RTE_ETH_XENVIRT_MAC_PARAM,
> sizeof(RTE_ETH_XENVIRT_MAC_PARAM))) {
> if (cmdline_parse_etheraddr(NULL,
> - pair[1],
> - &dict->addr) < 0) {
> + pair[1],
> + &dict->addr,
> + sizeof(struct ether_addr))
> < 0) {
Why not sizeof(dict->addr)?
--
Thomas
