> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, August 27, 2014 11:12 PM > To: Liu, Jijiang > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 3/7]rte_ether:add API of VxLAN packet filter > in librte_ether > > 2014-08-26 15:31, Jijiang Liu: > > +enum rte_tunnel_filter_type { > > + RTE_TUNNEL_FILTER_TYPE_NONE = 0, > > + RTE_TUNNEL_FILTER_IMAC_IVLAN, /**< Filter by inner MAC and VLAN ID. > */ > > + RTE_TUNNEL_FILTER_IMAC_IVLAN_TENID, > > + /**< Filter by inner MAC address and VLAN ID, tenned ID. */ > > + RTE_TUNNEL_FILTER_IMAC_TENID, /**< Filter by inner MAC and tenant > ID. */ > > + RTE_TUNNEL_FILTER_IMAC, /**< Filter by inner MAC address */ > > + RTE_TUNNEL_FILTER_OMAC_TENID_IMAC, > > + /**< Filter by outer MAC address, tenant ID and Inner MAC */ > > + RTE_TUNNEL_FILTER_TYPE_MAX, > > +}; > [...] > > /** > > + * Tunnel Packet filter configuration. > > + */ > > +struct rte_eth_tunnel_filter_conf { > > + struct ether_addr *outer_mac; /**< Outer MAC address fiter. */ > > + struct ether_addr *inner_mac; /**< Inner MAC address fiter. */ > > + uint16_t inner_vlan; /**< Inner VLAN fiter. */ > > + enum rte_tunnel_iptype ip_type; /**< IP address type. */ > > + union { > > + uint32_t ipv4_addr; /**< IPv4 source address to match. */ > > + uint32_t ipv6_addr[4]; /**< IPv6 source address to match. */ > > + } ip_addr; /**< IPv4/IPv6 source address to match (union of above). > > +*/ > > + > > + uint8_t filter_type; /**< Filter type. */ > > + uint8_t to_queue; /**< Use MAC and VLAN to point to a > queue. */ > > + enum rte_eth_tunnel_type tunnel_type; /**< Tunnel Type. */ > > + uint32_t tenant_id; /** < Tenant number. */ > > + uint16_t queue_id; /** < queue number. */ > > +}; > [...] > > +typedef int (*eth_tunnel_filter_set_t)(struct rte_eth_dev *dev, > > + struct rte_eth_tunnel_filter_conf > > *tunnel_filter, > > + uint8_t filter_count, uint8_t add); /**< > > @internal > Set > > +tunnel filter */ > [...] > > + /** > > + * Add tunnel filter configuration of Ethernet device > > + * > > + * @param port_id > > + * The port identifier of the Ethernet device. > > + * @param tunnel_filter > > + * Where to store the current Tunneling UDP configuration > > + * of the Ethernet device. > > + * @param filter_count > > + * How many filters are going to added. > > + * @param add > > + * 0: remove tunnel filter > > + * 1: add tunnel filter > > + * > > + * @return > > + * - (0) if successful. > > + * - (-ENODEV) if port identifier is invalid. > > + * - (-EINVAL) if bad parameter. > > + * - (-ENOTSUP) if hardware doesn't support tunnel type. > > + */ > > +int > > +rte_eth_dev_tunnel_filter_set(uint8_t port_id, > > + struct rte_eth_tunnel_filter_conf *tunnel_filter, > > + uint8_t filter_count, uint8_t add); > > I wonder if we could use a common function to set all kind of filters? > > Thoughts are welcome. > > -- > Thomas
The rte_eth_dev_tunnel_filter_set() is a common filter function for tunneling packet, which can set all kind of filters. But now I just implemented and tested VxLAN tunneling packet in this function, another tunneling packets support will be here later. Look at the structure definition, which support another tunneling types. struct rte_eth_tunnel_filter_conf ? ... enum rte_eth_tunnel_type tunnel_type; /**< Tunnel Type. */ ... } -- Jijiang Liu