Hi Thomas, The patch can be made without modifying ixgbe/ at all, I will make another attempt. Please see the proposal in my previous email. The question is how to keep the lpbk_mode field in struct rte_eth_conf future-proof. Or if this is overkill to think about possible future loopback support at this moment?
thx & rgds, -qinglai On Wed, Sep 25, 2013 at 5:47 PM, Thomas Monjalon <thomas.monjalon at 6wind.com> wrote: > 25/09/2013 16:12, Venkatesan, Venky : >> I for one would prefer that the changes not really modify any files in the >> librte_pmd_ixgbe/ixgbe directory. Those files are derived directly from >> the BSD driver baseline, and any changes will make future merges of newer >> code more challenging. The changes should be limited to files in the >> librte_pmd_ixgbe directory (and ethdev). > > I agree with Venky. > The poll-mode drivers e1000 and ixgbe are based on drivers located in > subdirectories e1000/ and ixgbe/. And by design, these poll-mode drivers use > the base drivers without modifying it. > So please try to restrict your changes to ixgbe_ethdev.c and ixgbe_rxtx.c. > > The coding rules are not written. If needed, we could add a file for it. > > Thanks for your patch > -- > Thomas
