25/09/2013 16:12, Venkatesan, Venky : > I for one would prefer that the changes not really modify any files in the > librte_pmd_ixgbe/ixgbe directory. Those files are derived directly from > the BSD driver baseline, and any changes will make future merges of newer > code more challenging. The changes should be limited to files in the > librte_pmd_ixgbe directory (and ethdev).
I agree with Venky. The poll-mode drivers e1000 and ixgbe are based on drivers located in subdirectories e1000/ and ixgbe/. And by design, these poll-mode drivers use the base drivers without modifying it. So please try to restrict your changes to ixgbe_ethdev.c and ixgbe_rxtx.c. The coding rules are not written. If needed, we could add a file for it. Thanks for your patch -- Thomas
