On Wed, 05 Jun 2013 16:50:03 +0200 Damien Millescamps <damien.millescamps at 6wind.com> wrote:
> Hi Stephen, > > Overall this patch is very nice. My only comment on this one is why do > you limit the max number of memory resources to 5 ? > The PCI configuration space permits to store up to 6 base addresses. > > > +#define PCI_MEM_RESOURCE 5 > > Please, can you add a log/comment with your patch, too ? > > > Cheers, Only because I was trying to save some space, and I didn't see any hardware with that many useful regions. Also the kernel UIO driver has some control over which regions get exposed.