zzzxl1993 commented on code in PR #245: URL: https://github.com/apache/doris-thirdparty/pull/245#discussion_r1827539630
########## cmake/FindZstd.cmake: ########## @@ -0,0 +1,68 @@ +# FindZstd.cmake +# Try to find or build the zstd library + +if(NOT TARGET zstd) + message(STATUS "Zstd target not found, checking for local sources...") + + # Set up paths for Zstd + set(ZSTD_VERSION "1.5.5") + set(ZSTD_URL "https://github.com/facebook/zstd/releases/download/v${ZSTD_VERSION}/zstd-${ZSTD_VERSION}.tar.gz";) Review Comment: done ########## src/core/CLucene/index/IndexWriter.cpp: ########## @@ -1383,7 +1388,7 @@ void IndexWriter::indexCompaction(std::vector<lucene::store::Directory *> &src_d proxOutputList.push_back(proxOut); // Instantiate a new termInfosWriter which will write in directory // for the segment name segment using the new merged fieldInfos - TermInfosWriter *termInfosWriter = _CLNEW TermInfosWriter(dest_dir, segment.c_str(), fieldInfos, termIndexInterval); + auto* termInfosWriter = _CLNEW STermInfosWriter<char>(dest_dir, segment.c_str(), fieldInfos, termIndexInterval); Review Comment: Because we have two types in clucene: STermInfosWriter and TermInfosWriter, I only modified the code logic in STermInfosWriter. My expectation is to maintain only one process within STermInfosWriter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
