DongLiang-0 commented on code in PR #35:
URL:
https://github.com/apache/doris-kafka-connector/pull/35#discussion_r1663789184
##########
src/main/java/org/apache/doris/kafka/connector/writer/load/DorisStreamLoad.java:
##########
@@ -126,4 +149,31 @@ private void refreshLoadUrl(String database, String table)
{
hostPort = backendUtils.getAvailableBackend();
loadUrl = String.format(LOAD_URL_PATTERN, hostPort, database, table);
}
+
+ private boolean isGroupCommitEnabled(DorisOptions dorisOptions) {
+ Properties streamLoadProp = dorisOptions.getStreamLoadProp();
+ if (streamLoadProp.containsKey(GROUP_COMMIT)) {
+
+ Object groupCommitMode = streamLoadProp.get(GROUP_COMMIT);
+ if (groupCommitMode.equals(GROUP_COMMIT_ASYNC_MODE)
+ || groupCommitMode.equals(GROUP_COMMIT_SYNC_MODE)) {
+ // When the group commit is enabled, some Stream Load and Http
Stream are not
+ // executed
+ // in the group commit way,refer to the
+ //
document:https://doris.apache.org/docs/data-operate/import/group-commit-manual/
+ if (dorisOptions.enable2PC()) {
Review Comment:
Parameter verification, you can put into
`org.apache.doris.kafka.connector.utils.ConfigCheckUtils.validateConfig(Map<String,
String> config)` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
