DongLiang-0 commented on code in PR #35:
URL:
https://github.com/apache/doris-kafka-connector/pull/35#discussion_r1663603514
##########
src/main/java/org/apache/doris/kafka/connector/writer/load/DorisStreamLoad.java:
##########
@@ -126,4 +147,10 @@ private void refreshLoadUrl(String database, String table)
{
hostPort = backendUtils.getAvailableBackend();
loadUrl = String.format(LOAD_URL_PATTERN, hostPort, database, table);
}
+
+ private boolean isGroupCommitEnabled(Properties streamLoadProp) {
+
+ return streamLoadProp.containsKey(GROUP_COMMIT)
+ &&
!streamLoadProp.get(GROUP_COMMIT).equals(GROUP_COMMIT_OFF_MODE);
Review Comment:
There may be some logic issues here. As long as the
`sink.properties.group_commit` parameter is filled in, group commit is enabled
regardless of whether it is `sync_mode`, and there is also a case problem.
I wonder if we can create a GroupCommit enum?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
