Hi Willem: Actually, the doris-flink-connector does not need a "binary release". So we decided to make a source release with a maven onvenience binaries. And for the binary release process, we may do it for the Doris main repo[1], like Doris(incubating) 1.0.0
We will start the doris-flink-connector[2] release poll again after we make changes to the issues pointed out in the thread. Thank you all [1] apache/incubator-doris [2] apache/incubator-doris-flink-connector -- 此致！Best Regards 陈明雨 Mingyu Chen Email: chenmin...@apache.org 在 2022-02-17 14:12:19，"Willem Jiang" <willem.ji...@gmail.com> 写道： >For the Java release, it doesn't need to do a lot of things for the >binary release. >Most java projects I know take care of the binary release kit when >doing the release as well. >I highly recommend we do the binary release of the doris connector this time. > >BTW, it could be a good experience for Doris to learn how to do the >binary release. > > >Willem Jiang > >Twitter: willemjiang >Weibo: 姜宁willem > >On Thu, Feb 17, 2022 at 1:29 PM 陈明雨 <morning...@163.com> wrote: >> >> Hi Willem, Kris: >> Thanks for your answers. >> >> >> So I understand that essentially we are still doing a "source release" >> rather than a "binary release". >> According to this understanding, we should not need to provide a separate >> License file for the "binary release". >> And the jars that end up in the maven repo are "Convenience binaries"[1]. >> Am I right? >> >> >> >> >> -- >> >> 此致！Best Regards >> 陈明雨 Mingyu Chen >> >> Email: >> chenmin...@apache.org >> >> >> >> >> >> 在 2022-02-17 12:13:44，"Calvin Kirs" <k...@apache.org> 写道： >> >I understand what you mean, if we need to package to maven, npmjs, pypi and >> >other platforms, we can publish it according to the rules of this platform, >> >no voting is required, but we must ensure that our source code is voted. >> > >> >And if we want to release our own binary package, we must vote according to >> >AL2's binary package release rules. >> > >> >Best wishes！ >> >CalvinKirs >> > >> >On 2022/02/17 03:04:46 陈明雨 wrote: >> >> Hi Kirs: >> >> >> >> >> >> Our purpose is to release this flink-connector in maven repo. It is more >> >> easy for user to use it. I don't know if this is considered a binary >> >> release? >> >> The release in [1] is indeed source code only, I wonder if it is released >> >> to maven, do we still need to put binary here as well? If yes, what >> >> binary do we need, put all jars in maven to the svn? >> >> >> >> >> >> [1] >> >> https://dist.apache.org/repos/dist/dev/incubator/doris/flink-connector/1.0.0/ >> >> >> >> >> >> >> >> -- >> >> >> >> 此致！Best Regards >> >> 陈明雨 Mingyu Chen >> >> >> >> Email: >> >> chenmin...@apache.org >> >> >> >> >> >> >> >> >> >> >> >> At 2022-02-17 01:24:39, "Calvin Kirs" <k...@apache.org> wrote: >> >> >hi, >> >> > >> >> > I want to confirm if we really need to release the binary package, I >> >> > checked the official documentation [1] and it seems we don't need to >> >> > release the binary package, the source package is enough. >> >> >Also this release [2] looks like you are only releasing the source >> >> >package. >> >> > >> >> >[1] >> >> >https://doris.apache.org/extending-doris/flink-doris-connector.html#an-example-of-using-flink-cdc-to-access-doris-supports- >> >> > insert-update-delete-events >> >> >[2] >> >> >https://dist.apache.org/repos/dist/dev/incubator/doris/flink-connector/1.0.0/ >> >> > >> >> >Best wishes！ >> >> >CalvinKirs >> >> > >> >> >On 2022/02/16 15:10:57 Calvin Kirs wrote: >> >> >> let me resolve this:) >> >> >> >> >> >> Best wishes！ >> >> >> CalvinKirs >> >> >> >> >> >> On 2022/02/16 12:42:50 Willem Jiang wrote: >> >> >> > The LICENSE-dependencies.txt file doesn't include the copyright >> >> >> > information of MIT and BSD. >> >> >> > I think we need to include those LICENSE file in the binary kit. >> >> >> > >> >> >> > >> >> >> > Willem Jiang >> >> >> > >> >> >> > Twitter: willemjiang >> >> >> > Weibo: 姜宁willem >> >> >> > >> >> >> > On Wed, Feb 16, 2022 at 5:34 PM 陈明雨 <morning...@163.com> wrote: >> >> >> > > >> >> >> > > Hi Willem: >> >> >> > > Thanks for you suggestion. >> >> >> > > >>BTW, for License compliance, if we do the binary release, we >> >> >> > > >>need to >> >> >> > > >>have a different license file for the binary kit. >> >> >> > > I refered to [1]. It says that we need a separete LICENSE file for >> >> >> > > binary release. Because the release pulls in and bundle additional >> >> >> > > dependencies which are not bundled with the source distribution. >> >> >> > > And yes we have this LICENSE file[2] in our code repo. Is that ok >> >> >> > > for binary release? Or do we need to make some special declaration >> >> >> > > for this license file? >> >> >> > > >> >> >> > > >> >> >> > > [1] https://infra.apache.org/licensing-howto.html#binary >> >> >> > > [2] >> >> >> > > https://github.com/apache/incubator-doris-flink-connector/blob/master/LICENSE-dependencies.txt >> >> >> > > >> >> >> > > >> >> >> > > >> >> >> > > -- >> >> >> > > >> >> >> > > 此致！Best Regards >> >> >> > > 陈明雨 Mingyu Chen >> >> >> > > >> >> >> > > Email: >> >> >> > > chenmin...@apache.org >> >> >> > > >> >> >> > > >> >> >> > > >> >> >> > > >> >> >> > > >> >> >> > > 在 2022-02-16 17:14:33，"陈明雨" <morning...@163.com> 写道： >> >> >> > > >Hi all, >> >> >> > > >Sorry that vote need to be cancelled. Because we need to modify >> >> >> > > >the way to build from release tag. >> >> >> > > > >> >> >> > > > >> >> >> > > > >> >> >> > > > >> >> >> > > >-- >> >> >> > > > >> >> >> > > >此致！Best Regards >> >> >> > > >陈明雨 Mingyu Chen >> >> >> > > > >> >> >> > > >Email: >> >> >> > > >chenmin...@apache.org >> >> >> > > > >> >> >> > > > >> >> >> > > > >> >> >> > > > >> >> >> > > > >> >> >> > > >At 2022-02-16 16:33:07, "Willem Jiang" <willem.ji...@gmail.com> >> >> >> > > >wrote: >> >> >> > > >>-1. >> >> >> > > >>I tried to build the binary from the source and found out the >> >> >> > > >>current >> >> >> > > >>source release needs to setup the scala and flink version from >> >> >> > > >>environment variables. >> >> >> > > >>It will cause some problems if the environment variables are not >> >> >> > > >>set. >> >> >> > > >>Please verify the maven release with some sample applications. >> >> >> > > >>I think we need to specify the version and run the test when >> >> >> > > >>building the kit. >> >> >> > > >> >> >> >> > > >>BTW, for License compliance, if we do the binary release, we >> >> >> > > >>need to >> >> >> > > >>have a different license file for the binary kit. >> >> >> > > >> >> >> >> > > >>Willem Jiang >> >> >> > > >> >> >> >> > > >>Twitter: willemjiang >> >> >> > > >>Weibo: 姜宁willem >> >> >> > > >> >> >> >> > > >>On Mon, Feb 14, 2022 at 5:04 PM 陈明雨 <morning...@163.com> wrote: >> >> >> > > >>> >> >> >> > > >>> Hi All, >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> This is a call for vote to release Flink Connectors v1.0.0 for >> >> >> > > >>> Apache Doris(Incubating). >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> There are 3 outputs for different Flink version: >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> - apache-doris-flink-connector-1.11.6-2.12-1.0.0-incubating >> >> >> > > >>> >> >> >> > > >>> - apache-doris-flink-connector-1.12.7-2.12-1.0.0-incubating >> >> >> > > >>> >> >> >> > > >>> - apache-doris-flink-connector-1.13.5-2.12-1.0.0-incubating >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> This is the first release of Doris Flink Connectors. >> >> >> > > >>> We have just moved the code from[1] to [2]. >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> The release candidates: >> >> >> > > >>> >> >> >> > > >>> https://dist.apache.org/repos/dist/dev/incubator/doris/flink-connector/1.0.0/ >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> Maven 2 staging repository: >> >> >> > > >>> >> >> >> > > >>> https://repository.apache.org/content/repositories/orgapachedoris-1002/org/apache/doris/doris-flink-connector/ >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> Git tag for the release: >> >> >> > > >>> >> >> >> > > >>> https://github.com/apache/incubator-doris-flink-connector/tree/1.11.6-2.12-1.0.0 >> >> >> > > >>> >> >> >> > > >>> https://github.com/apache/incubator-doris-flink-connector/tree/1.12.7-2.12-1.0.0 >> >> >> > > >>> >> >> >> > > >>> https://github.com/apache/incubator-doris-flink-connector/tree/1.13.5-2.12-1.0.0 >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> Keys to verify the Release Candidate: >> >> >> > > >>> >> >> >> > > >>> https://downloads.apache.org/incubator/doris/KEYS >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> Look at here for how to verify this release candidate: >> >> >> > > >>> >> >> >> > > >>> http://doris.incubator.apache.org/community/verify-apache-release.html >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> The vote will be open for at least 72 hours or until necessary >> >> >> > > >>> number of votes are reached. >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> Please vote accordingly: >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> [ ] +1 approve >> >> >> > > >>> >> >> >> > > >>> [ ] +0 no opinion >> >> >> > > >>> >> >> >> > > >>> [ ] -1 disapprove with the reason >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> [1] https://github.com/apache/incubator-doris >> >> >> > > >>> >> >> >> > > >>> [2] https://github.com/apache/incubator-doris-flink-connector >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> >> >> >> > > >>> -- >> >> >> > > >>> >> >> >> > > >>> 此致！Best Regards >> >> >> > > >>> 陈明雨 Mingyu Chen >> >> >> > > >>> >> >> >> > > >>> Email: >> >> >> > > >>> chenmin...@apache.org >> >> >> > > >> >> >> >> > > >>--------------------------------------------------------------------- >> >> >> > > >>To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org >> >> >> > > >>For additional commands, e-mail: dev-h...@doris.apache.org >> >> >> > >> >> >> > --------------------------------------------------------------------- >> >> >> > To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org >> >> >> > For additional commands, e-mail: dev-h...@doris.apache.org >> >> >> > >> >> >> > >> >> >> >> >> >> --------------------------------------------------------------------- >> >> >> To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org >> >> >> For additional commands, e-mail: dev-h...@doris.apache.org >> >> >> >> >> >> >> >> > >> >> >--------------------------------------------------------------------- >> >> >To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org >> >> >For additional commands, e-mail: dev-h...@doris.apache.org >> >> >> > >> >--------------------------------------------------------------------- >> >To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org >> >For additional commands, e-mail: dev-h...@doris.apache.org > >--------------------------------------------------------------------- >To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org >For additional commands, e-mail: dev-h...@doris.apache.org
