The LICENSE-dependencies.txt file doesn't include the copyright information of MIT and BSD. I think we need to include those LICENSE file in the binary kit.
Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Wed, Feb 16, 2022 at 5:34 PM 陈明雨 <morning...@163.com> wrote: > > Hi Willem: > Thanks for you suggestion. > >>BTW, for License compliance, if we do the binary release, we need to > >>have a different license file for the binary kit. > I refered to [1]. It says that we need a separete LICENSE file for binary > release. Because the release pulls in and bundle additional dependencies > which are not bundled with the source distribution. > And yes we have this LICENSE file[2] in our code repo. Is that ok for binary > release? Or do we need to make some special declaration for this license file? > > > [1] https://infra.apache.org/licensing-howto.html#binary > [2] > https://github.com/apache/incubator-doris-flink-connector/blob/master/LICENSE-dependencies.txt > > > > -- > > 此致!Best Regards > 陈明雨 Mingyu Chen > > Email: > chenmin...@apache.org > > > > > > 在 2022-02-16 17:14:33,"陈明雨" <morning...@163.com> 写道: > >Hi all, > >Sorry that vote need to be cancelled. Because we need to modify the way to > >build from release tag. > > > > > > > > > >-- > > > >此致!Best Regards > >陈明雨 Mingyu Chen > > > >Email: > >chenmin...@apache.org > > > > > > > > > > > >At 2022-02-16 16:33:07, "Willem Jiang" <willem.ji...@gmail.com> wrote: > >>-1. > >>I tried to build the binary from the source and found out the current > >>source release needs to setup the scala and flink version from > >>environment variables. > >>It will cause some problems if the environment variables are not set. > >>Please verify the maven release with some sample applications. > >>I think we need to specify the version and run the test when building the > >>kit. > >> > >>BTW, for License compliance, if we do the binary release, we need to > >>have a different license file for the binary kit. > >> > >>Willem Jiang > >> > >>Twitter: willemjiang > >>Weibo: 姜宁willem > >> > >>On Mon, Feb 14, 2022 at 5:04 PM 陈明雨 <morning...@163.com> wrote: > >>> > >>> Hi All, > >>> > >>> > >>> > >>> > >>> This is a call for vote to release Flink Connectors v1.0.0 for Apache > >>> Doris(Incubating). > >>> > >>> > >>> > >>> > >>> There are 3 outputs for different Flink version: > >>> > >>> > >>> > >>> > >>> - apache-doris-flink-connector-1.11.6-2.12-1.0.0-incubating > >>> > >>> - apache-doris-flink-connector-1.12.7-2.12-1.0.0-incubating > >>> > >>> - apache-doris-flink-connector-1.13.5-2.12-1.0.0-incubating > >>> > >>> > >>> > >>> > >>> This is the first release of Doris Flink Connectors. > >>> We have just moved the code from[1] to [2]. > >>> > >>> > >>> > >>> > >>> The release candidates: > >>> > >>> https://dist.apache.org/repos/dist/dev/incubator/doris/flink-connector/1.0.0/ > >>> > >>> > >>> > >>> > >>> Maven 2 staging repository: > >>> > >>> https://repository.apache.org/content/repositories/orgapachedoris-1002/org/apache/doris/doris-flink-connector/ > >>> > >>> > >>> > >>> > >>> Git tag for the release: > >>> > >>> https://github.com/apache/incubator-doris-flink-connector/tree/1.11.6-2.12-1.0.0 > >>> > >>> https://github.com/apache/incubator-doris-flink-connector/tree/1.12.7-2.12-1.0.0 > >>> > >>> https://github.com/apache/incubator-doris-flink-connector/tree/1.13.5-2.12-1.0.0 > >>> > >>> > >>> > >>> > >>> Keys to verify the Release Candidate: > >>> > >>> https://downloads.apache.org/incubator/doris/KEYS > >>> > >>> > >>> > >>> > >>> Look at here for how to verify this release candidate: > >>> > >>> http://doris.incubator.apache.org/community/verify-apache-release.html > >>> > >>> > >>> > >>> > >>> The vote will be open for at least 72 hours or until necessary number of > >>> votes are reached. > >>> > >>> > >>> > >>> > >>> Please vote accordingly: > >>> > >>> > >>> > >>> > >>> [ ] +1 approve > >>> > >>> [ ] +0 no opinion > >>> > >>> [ ] -1 disapprove with the reason > >>> > >>> > >>> > >>> > >>> [1] https://github.com/apache/incubator-doris > >>> > >>> [2] https://github.com/apache/incubator-doris-flink-connector > >>> > >>> > >>> > >>> > >>> -- > >>> > >>> 此致!Best Regards > >>> 陈明雨 Mingyu Chen > >>> > >>> Email: > >>> chenmin...@apache.org > >> > >>--------------------------------------------------------------------- > >>To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org > >>For additional commands, e-mail: dev-h...@doris.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org