gaodayue commented on a change in pull request #1409: Add dict page
URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299284866
##########
File path: be/src/olap/rowset/segment_v2/options.h
##########
@@ -17,20 +17,19 @@
#pragma once
-#include "gen_cpp/segment_v2.pb.h"
-#include "olap/rowset/segment_v2/page_decoder.h" // for PageDecoder
-
namespace doris {
namespace segment_v2 {
+class BinaryPlainPageDecoder;
+
struct PageBuilderOptions {
size_t data_page_size = 0;
size_t dict_page_size = 0;
Review comment:
Use a reasonable defaults other than 0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
