gaodayue commented on a change in pull request #1409: Add dict page
URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299289567
##########
File path: be/src/olap/rowset/segment_v2/encoding_info.h
##########
@@ -31,8 +34,6 @@ namespace segment_v2 {
class PageBuilder;
class PageDecoder;
Review comment:
forward declaration of PageBuilder and PageDecoder could also be removed
since we've included the header
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
