imay commented on a change in pull request #1289: Modify colocation creation
logic
URL: https://github.com/apache/incubator-doris/pull/1289#discussion_r293771381
##########
File path: fe/src/main/java/org/apache/doris/http/meta/ColocateMetaService.java
##########
@@ -54,8 +58,11 @@
private static ColocateTableIndex colocateIndex =
Catalog.getCurrentColocateIndex();
- private static long checkAndGetGroupId(BaseRequest request) throws
DdlException {
- long groupId =
Long.valueOf(request.getSingleParameter(GROUP_ID).trim());
+ private static GroupId checkAndGetGroupId(BaseRequest request) throws
DdlException {
+ long grpId = Long.valueOf(request.getSingleParameter(GROUP_ID).trim());
+ long dbId = Long.valueOf(request.getSingleParameter(DB_ID).trim());
+ GroupId groupId = new GroupId(dbId, grpId);
+
Review comment:
can you move this file to our documents?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
