imay commented on a change in pull request #1289: Modify colocation creation
logic
URL: https://github.com/apache/incubator-doris/pull/1289#discussion_r292979555
##########
File path: fe/src/main/java/org/apache/doris/catalog/CatalogRecycleBin.java
##########
@@ -277,6 +284,12 @@ public synchronized void replayEraseTable(long tableId) {
}
}
+ // colocation
+ if (Catalog.getCurrentColocateIndex().removeTable(tableId)) {
+ ColocatePersistInfo colocateInfo =
ColocatePersistInfo.createForRemoveTable(tableId);
Review comment:
when we replay erase table? Why we need to logColocateRemoveTable. I think
when this log had been logged, the logColocateRemoveTable had been logged too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
