kangpinghuang commented on a change in pull request #912: Remove data_dir
pointer from TabletMeta
URL: https://github.com/apache/incubator-doris/pull/912#discussion_r274793601
##########
File path: be/src/olap/tablet_manager.cpp
##########
@@ -686,7 +686,7 @@ TabletSharedPtr
TabletManager::find_best_tablet_to_compaction(CompactionType com
OLAPStatus TabletManager::load_tablet_from_meta(DataDir* data_dir, TTabletId
tablet_id,
TSchemaHash schema_hash, const std::string& meta_binary) {
- TabletMetaSharedPtr tablet_meta(new TabletMeta());
+ TabletMetaSharedPtr tablet_meta(new (nothrow) TabletMeta());
Review comment:
```suggestion
TabletMetaSharedPtr tablet_meta(new(nothrow) TabletMeta());
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
