kangpinghuang commented on a change in pull request #912: Remove data_dir
pointer from TabletMeta
URL: https://github.com/apache/incubator-doris/pull/912#discussion_r274793908
##########
File path: be/src/olap/snapshot_manager.cpp
##########
@@ -497,7 +497,7 @@ OLAPStatus SnapshotManager::_append_single_delta(
const TSnapshotRequest& request, DataDir* store) {
OLAPStatus res = OLAP_SUCCESS;
string root_path = store->path();
- TabletMetaSharedPtr new_tablet_meta(new(nothrow) TabletMeta(store));
+ TabletMetaSharedPtr new_tablet_meta(new (nothrow) TabletMeta());
Review comment:
```suggestion
TabletMetaSharedPtr new_tablet_meta(new(nothrow) TabletMeta());
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
