imay commented on a change in pull request #562: Add ColocateMetaService
URL: https://github.com/apache/incubator-doris/pull/562#discussion_r250437314
 
 
 ##########
 File path: 
fe/src/main/java/org/apache/doris/http/common/DorisHttpObjectAggregator.java
 ##########
 @@ -0,0 +1,62 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.http.common;
+
+import io.netty.channel.ChannelPipeline;
+import io.netty.handler.codec.http.HttpContent;
+import io.netty.handler.codec.http.HttpMessage;
+import io.netty.handler.codec.http.HttpObject;
+import io.netty.handler.codec.http.HttpObjectAggregator;
+import io.netty.handler.codec.http.HttpRequest;
+import io.netty.handler.codec.http.HttpUtil;
+
+/*
+ * don't handle 100-continue and chunked transfer-encoding http header
+ */
+public class DorisHttpObjectAggregator extends HttpObjectAggregator {
+    // the flag for aggregator whether has started
+    // in order not to handle chunked transfer-encoding header in {@link 
isContentMessage} method
 
 Review comment:
   OK, I see
   
   I think enabling chunked encoding in this aggregator is acceptable.
   
   1. If you apply this aggregator to all HTTP method, when client send `Load` 
request with "Content-Length" header and without "100-continue", this 
aggregator would also receive data. There is no difference between chunked or 
non chunked.
   
   2. If you only apply this aggregator to POST method. it's OK to receive 
chunked encoding body to POST action.  This aggregator won't receive body for 
`Load` action.
   
   So, I think you can let the aggregator to receive chunked body
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org

Reply via email to