imay commented on a change in pull request #562: Add ColocateMetaService URL: https://github.com/apache/incubator-doris/pull/562#discussion_r250162919
########## File path: fe/src/main/java/org/apache/doris/http/common/DorisHttpObjectAggregator.java ########## @@ -0,0 +1,62 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.http.common; + +import io.netty.channel.ChannelPipeline; +import io.netty.handler.codec.http.HttpContent; +import io.netty.handler.codec.http.HttpMessage; +import io.netty.handler.codec.http.HttpObject; +import io.netty.handler.codec.http.HttpObjectAggregator; +import io.netty.handler.codec.http.HttpRequest; +import io.netty.handler.codec.http.HttpUtil; + +/* + * don't handle 100-continue and chunked transfer-encoding http header + */ +public class DorisHttpObjectAggregator extends HttpObjectAggregator { + // the flag for aggregator whether has started + // in order not to handle chunked transfer-encoding header in {@link isContentMessage} method Review comment: The followings are what I want to figure out for current `DorisHttpObjectAggregator` 1. If request has 100-continue header, does it receive request body before call action's handler? If this is true, I think in normal case for `LoadAction`, FE won't receive load data. 2. If request has no 100-continue header and request body is exceed max body size, will it return an error response to client ? If this is true, I think it's OK to receive relatively small data, however it is difficult to let client known that request misses 100-continue header, because aggregator is a common path for all input HTTP request. Making `DorisHttpObjectAggregator` only apply POST request seems OK. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
