imay commented on a change in pull request #456: Add routine load statement
URL: https://github.com/apache/incubator-doris/pull/456#discussion_r244903984
##########
File path:
fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadManager.java
##########
@@ -132,8 +149,140 @@ public void addNumOfConcurrentTasksByBeId(long beId) {
}
}
- public void addRoutineLoadJob(RoutineLoadJob routineLoadJob) {
- idToRoutineLoadJob.put(routineLoadJob.getId(), routineLoadJob);
+ public void addRoutineLoadJob(CreateRoutineLoadStmt createRoutineLoadStmt)
+ throws AnalysisException, DdlException, LoadException {
+ // check load auth
Review comment:
I think it's better to move auth check to statement analysis. Then this
class needs not to know about auth things
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
