imay commented on a change in pull request #456: Add routine load statement
URL: https://github.com/apache/incubator-doris/pull/456#discussion_r243995696
##########
File path:
fe/src/main/java/org/apache/doris/load/routineload/KafkaRoutineLoadJob.java
##########
@@ -55,16 +58,26 @@
// optional, user want to load partitions.
private List<Integer> kafkaPartitions;
- public KafkaRoutineLoadJob() {
+ public KafkaRoutineLoadJob(String name, String userName, long dbId, long
tableId,
Review comment:
I think there is too many arguments.
dataSourceType only can be Kafka, why you need user to pass it, and also
state.
you should reduce its arguments number
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
