yiguolei commented on a change in pull request #452: Add AlphaRowsetMeta and
AlphaRowsetReader
URL: https://github.com/apache/incubator-doris/pull/452#discussion_r243485196
##########
File path: be/src/olap/segment_group.cpp
##########
@@ -276,28 +324,26 @@ OLAPStatus SegmentGroup::load() {
}
if (_index.init(_short_key_length, _new_short_key_length,
- _tablet->num_short_key_fields(), &_short_key_info_list) !=
OLAP_SUCCESS) {
+ _num_short_key_fields, &_short_key_info_list) !=
OLAP_SUCCESS) {
OLAP_LOG_WARNING("fail to create MemIndex. [num_segment=%d]",
_num_segments);
return res;
}
// for each segment
for (uint32_t seg_id = 0; seg_id < _num_segments; ++seg_id) {
- if (COLUMN_ORIENTED_FILE == _tablet->data_file_type()) {
- string seg_path = construct_data_file_path(_segment_group_id,
seg_id);
- if (OLAP_SUCCESS != (res = load_pb(seg_path.c_str(), seg_id))) {
- LOG(WARNING) << "failed to load pb structures. [seg_path='" <<
seg_path << "']";
- _check_io_error(res);
- return res;
- }
+ string seg_path = construct_data_file_path(_segment_group_id, seg_id);
+ if (OLAP_SUCCESS != (res = load_pb(seg_path.c_str(), seg_id))) {
+ LOG(WARNING) << "failed to load pb structures. [seg_path='" <<
seg_path << "']";
+
+ return res;
}
-
+
// get full path for one segment
string path = construct_index_file_path(_segment_group_id, seg_id);
Review comment:
why not use _construct_file_path?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
