yiguolei commented on a change in pull request #452: Add AlphaRowsetMeta and
AlphaRowsetReader
URL: https://github.com/apache/incubator-doris/pull/452#discussion_r243485325
##########
File path: be/src/olap/segment_group.cpp
##########
@@ -551,23 +595,20 @@ OLAPStatus SegmentGroup::add_short_key(const RowCursor&
short_key, const uint32_
char errmsg[64];
LOG(WARNING) << "can not create file. [file_path='" << file_path
<< "' err='" << strerror_r(errno, errmsg, 64) << "']";
- _check_io_error(res);
return res;
}
_new_segment_created = true;
// 准备FileHeader
if ((res = _file_header.prepare(&_current_file_handler)) !=
OLAP_SUCCESS) {
OLAP_LOG_WARNING("write file header error. [err=%m]");
- _check_io_error(res);
return res;
}
// 跳过FileHeader
if (_current_file_handler.seek(_file_header.size(), SEEK_SET) == -1) {
OLAP_LOG_WARNING("lseek header file error. [err=%m]");
res = OLAP_ERR_IO_ERROR;
- _check_io_error(res);
Review comment:
@chaoyli pay attention to this!!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
