gnodet commented on PR #2946: URL: https://github.com/apache/cxf/pull/2946#issuecomment-4040561665
@reta thank you for the feedback. You're right that the tracing changes were too broad. Regarding the specific points: - **Tracing timeouts**: Agreed — if the tests are stable on CI, increasing timeouts isn't the right fix. - **`@Before` cleanup**: I understand — `@After` + `OpenTelemetryRule` should be sufficient within a class, and the static `TestSpanHandler.SPANS` list shouldn't leak between classes since each test class creates its own `Tracing` instance. - **JMS**: The race condition fix (moving null check inside `synchronized`) is a genuine TOCTOU bug — if a message arrives between `inMessage.get() == null` and `inMessage.wait()`, the notification is lost. However, I agree that some JMS failures are caused by messages simply not arriving (I observed 2 flakes even with the fix applied locally). I've created #2947 with only the Undertow `@After` cleanup and JMS race condition fix, dropping all tracing changes. Closing this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
