reta commented on code in PR #2946:
URL: https://github.com/apache/cxf/pull/2946#discussion_r2919330019
##########
systests/tracing/src/test/java/org/apache/cxf/systest/jaxrs/tracing/opentelemetry/OpenTelemetryTracingTest.java:
##########
@@ -122,6 +123,11 @@ private static Context fromRandom() {
TraceState.getDefault())));
}
+ @Before
+ public void setUp() {
+ otelRule.clearSpans();
Review Comment:
This is not need, the whole purpose of using OpenTelemetryRule (JUnit rule)
is automatic setup / teardown logic
##########
systests/tracing/src/test/java/org/apache/cxf/systest/jaxrs/tracing/opentelemetry/OpenTelemetryTracingTest.java:
##########
@@ -122,6 +123,11 @@ private static Context fromRandom() {
TraceState.getDefault())));
}
+ @Before
+ public void setUp() {
+ otelRule.clearSpans();
Review Comment:
This is not needed, the whole purpose of using OpenTelemetryRule (JUnit
rule) is automatic setup / teardown logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
