reta commented on code in PR #1978:
URL: https://github.com/apache/cxf/pull/1978#discussion_r1700902908
##########
services/sts/sts-core/src/test/java/org/apache/cxf/sts/operation/ValidateJWTTransformationTest.java:
##########
@@ -206,7 +206,9 @@ public void testJWTToSAMLTransformationRealm() throws
Exception {
TokenProviderResponse providerResponse = createJWT();
Element wrapper =
createTokenWrapper((String)providerResponse.getToken());
Document doc = wrapper.getOwnerDocument();
- wrapper = (Element)doc.appendChild(wrapper);
+ if (doc.getDocumentElement() == null) {
Review Comment:
@kaiyaok2 I think this test should be refactored to create a new document
(vs manipulating empty one which is static):
```
private Element createTokenWrapper(String token) {
Document doc = DOMUtils.createDocument();
Element tokenWrapper = doc.createElementNS(null, "TokenWrapper");
tokenWrapper.setTextContent(token);
return tokenWrapper;
}
```
Could you please make a change? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
