JohnMTu commented on PR #1150: URL: https://github.com/apache/cxf/pull/1150#issuecomment-1610970541
hello, @reta: so far i removed "final" from maskSensitiveHelper field and added setters. Hence subclasses can be passed. In next step i tried to extract interface. Here I realized there is some inconsistency, as configuration used for hiding data is in once case on Interceptor org.apache.cxf.ext.logging.AbstractLoggingInterceptor#sensitiveProtocolHeaderNames while in other case it's near to implementation in org.apache.cxf.ext.logging.DefaultMaskSensitiveHelper#replacementsJSON (and replacementsXML). Best would be to cleanup it and keep it next to implementation, but unfortunately that would mean to change to some public methods, e.g. org.apache.cxf.ext.logging.event.DefaultLogEventMapper#map(org.apache.cxf.message.Message, java.util.Set<java.lang.String>) would not need 2nd argument anymore. And also org.apache.cxf.ext.logging.MaskSensitiveHelper#maskHeaders would not need it. Anyway, i'm not sure, if even change MaskSensitiveHelper to from class to interface is allowed in terms of backward compatibility. Please give me some hints, So here is my attempt: https://github.com/JohnMTu/cxf/compare/3.5.x-fixes...JohnMTu:cxf:CXF-8831_extract_interface?expand=1 Unfortunately github doesn't show rename of MaskSensitiveHelper to DefaultMaskSensitiveHelper and instead shows diff against extracted interface .. but when checking commit by commit, rename is visible. Not sure how it would look like, if squash would be used. Please check. Thanks you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
