reta commented on PR #1150: URL: https://github.com/apache/cxf/pull/1150#issuecomment-1485877719
> @reta : This is ticket i just made https://issues.apache.org/jira/browse/CXF-8831 Thank you @JohnMTu ! > Having option to provide own instance of MaskSensitiveHelper subclass would be also fine for me. Perhaps it can be even refactored to interface. I think extracting interface would be cleaner in general > Only not so nice thing might be, that method setSensitiveElementNames is invoked from AbstractLoggingInterceptor#setSensitiveElementNames and LoggingFeature and LoggingFeature.Portable. Similar for setSensitiveProtocolHeaderNames. In case of our implementation such method would have no use. But for backward compatibility we would need to keep them. Yes, the delegation model could be used instead (in this regards, subclassing would be simpler than interface extraction), but preserving backward compatibility is necessary. > > Do you want to do stuff yourself, or should i provide it? If i should do it, do you prefer to keep MaskSensitiveHelper a class or should be interface refactored out of it? Up to you, would be great if you finish the change since this is your idea and most of the work is done already. I am not sure you have time though (no pressure). > > thanks Thanks to you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
