ffang commented on issue #365: [CXF-7520]:Ensure CXF can build with JDK9 
GA(build 9+181)
URL: https://github.com/apache/cxf/pull/365#issuecomment-357142609
 
 
   And about the customized NoEscapeHandler itself, IMO we cannot simply do 
   `out.write(ch, start, length);`
   
   We should keep most part from CharacterEscapeHandler as is, check change 
this line
   `if (lastEscaped != limit) { //here if char[] ch lenght is 0, then there's 
no way to run into the out.write
                   out.write(ch, lastEscaped, length - lastEscaped);
               }`
   shouldn't detect if lastEscaped != limit or not, just ensure out.write is 
invoked so that any registered underlying  XMLStreamWriter get chance to be 
invoked to do any necessary work we want.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to