Hi Andriy, I can confirm that only one test is failing now (sporadically):
Tests in error: TomcatBroadcasterTest>AbstractBroadcasterSseTest.testBooksStreamIsBroadcasted:59 » ResponseProcessing Colm. On Mon, Sep 26, 2016 at 3:23 AM, Andriy Redko <[email protected]> wrote: > Hey Sergey, > > Worked on SSE test cases staibility over the week-end. Got to the point > when there is one > failure (with Tomcat this time) but not all the time. Could I ask you > please to run SSE > test suiteon your Linux box couple of times to verify how stable it is? > Thanks a lot, > much appreciated! > > Best Regards, > Andriy Redko > > SB> Hi Andriy > > SB> Interesting. I wonder if Jetty can be tuned somehow so that as far as > SB> ATM is concerned the same code path is used there irrespectively of > SB> whether it is Jetty or Tomcat - given that with Tomcat the tests pass > > SB> Thanks, Sergey > SB> On 23/09/16 11:22, Andriy Redko wrote: > >> Hey Sergey, > > >> Yeah, I have gotten all them green on my machine (always failing > before) and > >> thought they are fixed now, will look more today. It is definitely Jetty > >> specific, I know why Jetty fails but I have not found a way to > workaround > >> that (it is deeply inside Atm). I will spend more time today and in > worst > >> case just please comment them out if it something blocking you guys. > > >> Thanks! > > >> Best Regards, > >> Andriy Redko > > >> SB> Looks like it is a test (or SSE impl) state issue, > >> SB> Andriy, FYI, if I run complete JettyEmbeddedTest then I see: > > > >> SB> testBooksStreamIsReturnedFromLastEventId - OK > >> SB> testBooksAreReturned - Fail > > >> SB> If I only run > > >> SB> JettyEmbeddedTest.testBooksAreReturned > > >> SB> then it is green. > > >> SB> Same tests run with Tomcat though (I wonder by the way if CXF should > >> SB> have an http-tomcat transport too). > >> SB> So may be it is Jetty specific ? > > >> SB> Cheers, Sergey > > >> SB> On 23/09/16 10:14, Colm O hEigeartaigh wrote: > >>>> No apologies necessary Andriy! We all inadvertently break tests. > > >>>> Both tests are still failing for me however: > > >>>> Failed tests: > > >>>> JettyEmbeddedTest>AbstractSseTest.testBooksAreReturned:62-> > Assert.assertEquals:631->Assert.assertEquals:645-> > Assert.failNotEquals:834->Assert.fail:88 > >>>> expected:<200> but was:<500> > > >>>> JettyWarTest>AbstractSseTest.testBooksAreReturned:62-> > Assert.assertEquals:631->Assert.assertEquals:645-> > Assert.failNotEquals:834->Assert.fail:88 > >>>> expected:<200> but was:<500> > > >>>> My Java version is "1.8.0_101" on linux if that helps. > > >>>> Colm. > > >>>> On Fri, Sep 23, 2016 at 2:33 AM, Andriy Redko <[email protected]> > wrote: > > >>>>> Hey Colm, > > >>>>> My bad, worked on a solution but it took awhile. The fix was finally > >>>>> committed a few > >>>>> minutes ago, should be OK from now on. Please accept my apologies. > > >>>>> Best Regards, > >>>>> Andriy Redko > > >>>>> COh> The following tests are failing for me on the master branch: > > >>>>> COh> Failed tests: > > >>>>> JettyEmbeddedTest>>AbstractSseTest.testBooksAreReturned:73-> > >>>>> Assert.assertEquals:631->Assert.assertEquals:645-> > >>>>> Assert.failNotEquals:834->Assert.fail:88 > >>>>> COh> expected:<200> but was:<500> > > >>>>> JettyWarTest>>AbstractSseTest.testBooksAreReturned:73-> > >>>>> Assert.assertEquals:631->Assert.assertEquals:645-> > >>>>> Assert.failNotEquals:834->Assert.fail:88 > >>>>> COh> expected:<200> but was:<500> > >>>>> COh> Tests in error: > >>>>> COh> TomcatEmbeddedTest>AbstractSseTest. > testBooksStreamIsBroadcasted:101 > >>>>> » > >>>>> COh> ResponseProcessing > > > > > > > > > > > > > > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com
