Looks like it is a test (or SSE impl) state issue,
Andriy, FYI, if I run complete JettyEmbeddedTest then I see:


testBooksStreamIsReturnedFromLastEventId - OK
testBooksAreReturned - Fail

If I only run

JettyEmbeddedTest.testBooksAreReturned

then it is green.

Same tests run with Tomcat though (I wonder by the way if CXF should have an http-tomcat transport too).
So may be it is Jetty specific ?

Cheers, Sergey

On 23/09/16 10:14, Colm O hEigeartaigh wrote:
No apologies necessary Andriy! We all inadvertently break tests.

Both tests are still failing for me however:

Failed tests:

JettyEmbeddedTest>AbstractSseTest.testBooksAreReturned:62->Assert.assertEquals:631->Assert.assertEquals:645->Assert.failNotEquals:834->Assert.fail:88
expected:<200> but was:<500>

JettyWarTest>AbstractSseTest.testBooksAreReturned:62->Assert.assertEquals:631->Assert.assertEquals:645->Assert.failNotEquals:834->Assert.fail:88
expected:<200> but was:<500>

My Java version is "1.8.0_101" on linux if that helps.

Colm.

On Fri, Sep 23, 2016 at 2:33 AM, Andriy Redko <[email protected]> wrote:

Hey Colm,

My bad, worked on a solution but it took awhile. The fix was finally
committed a few
minutes ago, should be OK from now on. Please accept my apologies.

Best Regards,
    Andriy Redko

COh> The following tests are failing for me on the master branch:

COh> Failed tests:

JettyEmbeddedTest>>AbstractSseTest.testBooksAreReturned:73->
Assert.assertEquals:631->Assert.assertEquals:645->
Assert.failNotEquals:834->Assert.fail:88
COh> expected:<200> but was:<500>

JettyWarTest>>AbstractSseTest.testBooksAreReturned:73->
Assert.assertEquals:631->Assert.assertEquals:645->
Assert.failNotEquals:834->Assert.fail:88
COh> expected:<200> but was:<500>
COh> Tests in error:
COh>   TomcatEmbeddedTest>AbstractSseTest.testBooksStreamIsBroadcasted:101
ยป
COh> ResponseProcessing









--
Sergey Beryozkin

Talend Community Coders
http://coders.talend.com/

Reply via email to