Hi Kean I hope this doesn't make you regret having mentioned that you wrote the LabValueFinder in an email a few weeks back... (:-)
I've been trying to figure out why it isn't working for me in a production setting. So I'm now just running it with its own unit tests (which I turned into a simple Junit test) against the usual sno_rx_16ab dictionary. They all fail. I added one extremely simple test to your more complex ones, but that fails too - which makes me think there's something fundamental that may be easy to fix It finds the concepts and many of the candidate "values" but matches the wrong value or no value with a concept. The debug output shows odd things like this: Two entries for one concept but with different search windows, one of them with window begin and end swapped. *24 Dec 2020 12:56:38 DEBUG LabValueFinder - Seeking value for: LabMention(14-21): Lactate between 21 and 1424 Dec 2020 12:56:38 DEBUG LabValueFinder - Seeking value for: LabMention(14-21): Lactate between 21 and 29* I've been going through the code, but it would probably be easier for you to spot the issue rather than a person unfamiliar with it. Do you have a moment? I've attached the Junit test based off your unit test and its debug output. You'll have to change the package name, though. Peter
