On Tue, Apr 11, 2023 at 10:08 AM Norman Breau <nor...@nbsolutions.ca> wrote: > > I also want to point out (as we ran into issues cherry-picking and > testing locally against our apps) > that dpogue's PR for NodeJS 18 support won't be cherry-picked easily as > the function > being changed has been renamed at > https://github.com/apache/cordova-ios/commit/21983197042908dff4cd49b00728b0c1d6703322
The function name changed, but the implementation didn't, so backporting it manually shouldn't be an issue. If the PR gets accepted to master, I'm happy to do the backport to 6.x. > So it might be easier to cut off NodeJS 18 support off in > cordova-ios@6.x (We have never claimed support for it anyway) > and officially support NodeJS starting in cordova-ios@7 My concern here is just that node 18 is already LTS, and it feels like we'd be under increased pressure to get 7.0.0 out the door just to fix this particular bug. Which is to say, I'm +1 on including both of the fixes in a 6.x release in the near future. ~Darryl --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
