I also want to point out (as we ran into issues cherry-picking and
testing locally against our apps)
that dpogue's PR for NodeJS 18 support won't be cherry-picked easily as
the function
being changed has been renamed at
https://github.com/apache/cordova-ios/commit/21983197042908dff4cd49b00728b0c1d6703322
So it might be easier to cut off NodeJS 18 support off in
cordova-ios@6.x (We have never claimed support for it anyway)
and officially support NodeJS starting in cordova-ios@7
On 2023-04-11 10:00 a.m., Norman Breau wrote:
I agree that 7.0.0 isn't necessary ready yet.
I think we have some plumbing to do and see if there are other
issues that warrants introducing further breaking changes and such.
I also think we should have a (separate) discussion on if minimum
deployment target 11
should be kept around for 7.x release.
However if you want to make a smaller stopgap release and build a new
6.x version, I don't
have any problems with that either. I agree with jcesar here that the
change for
inspectable webviews should be considered a feature, not a fix. This
change is
in response to the new feature in iOS 16.4 which allows webviews to be
inspectable
regardless of build settings. So I think the version should be a 6.3.0
product.
If you choose to build a 6.3.0 version, I'm sure our user base will
appreciate the effort, since it will allow them to test iOS 16.4 without
upgrading to a new major version.
Cheers,
Norman
On 2023-04-11 6:07 a.m., Niklas Merz wrote:
I could also do this as a patch release, then. The goal of this release
is to just get debugging possible again and fix NodeJS 18 with these two
PRs.
I think the major release is not quite ready. But correct me if I'm
wrong. There is some stuff to do and review.
What do you think?
On April 11, 2023, julio cesar sanchez <jcesarmob...@gmail.com> wrote:
Can’t we do a major release?
Last release was over two years ago and I think we have a lot more
fixes
and features than just the inspector fix, that would benefit users.
If not, it should be a minor release, not a patch release, since the
inspector fix is actually a feature.
El martes, 11 de abril de 2023, Niklas Merz <niklasm...@apache.org>
escribió:
Does anyone have any reason to delay a path release with iOS and
NodeJS
related fixes release?
Any outstanding patches to land?
If not, I will start the in the upcoming days.
I would merge this PR [1] and use the 6.2.x [2] branch with the
WebView
[3] inspect fix.
[1] https://github.com/apache/cordova-ios/pull/1302
[2] https://github.com/apache/cordova-ios/tree/6.2.x
[3] https://github.com/apache/cordova-ios/pull/1300
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
