I think we are almost ready for cordova-andropid@8.0.0 release, should finish the following:
* review and merge the following proposed PRs: - https://github.com/apache/cordova-android/pull/656 - https://github.com/apache/cordova-android/pull/663 - https://github.com/apache/cordova-android/pull/664 * then I can go through the final testing and review of proposal in https://github.com/apache/cordova-android/pull/655 On Fri, Feb 8, 2019 at 2:58 PM Chris Brody <chris.br...@gmail.com> wrote: > > I think it would be a pretty bad reflection on Apache Cordova if we > would announce a new release that is known to depend on deprecated > platform behavior. Not supporting AndroidX would be a prime example. I > think it would also be pretty bad if a bug such as bug 508 would be > introduced in the middle of the most recent release and not resolved > before we make a new major release. > > That said, I think we have determined on GitHub that there is no issue > with using cordova-android@8 (nightly) with AndroidX. The PSPDF team > reported that this is only an issue with our plugins. (And from a > quick scan I think the number of affected Apache Cordova plugins would > be very limited limited.) So I would conclude that the issue with > AndroidX should be blocking for Cordova CLI (and cordova-lib) but > **not** for cordova-android. > > I would personally favor making the new cordova-android release once > the following PRs are finished, reviewed, and merged: > > * https://github.com/apache/cordova-android/pull/655 - needs review > * https://github.com/apache/cordova-android/pull/656 - quick fix > proposal that I just made > > and less importantly: > > * https://github.com/apache/cordova-android/pull/642 - needs a review > before merging > * https://github.com/apache/cordova-android/pull/632 - needs a review > before merging > > I do think there are quite a few more issues that should be resolved > in a future cordova-android / Cordova CLI release. Yes we can always > make a new major release whenever it is needed. > > On Fri, Feb 8, 2019 at 6:59 AM Jan Piotrowski <piotrow...@gmail.com> wrote: > > > > Let me correct my question then: > > Why are those blocking and can not be added in a future major > > cordova-android release (with an accompanying CLI release that adds > > this as the new default android version to be installed if that is > > still necessary) when those changes are merged? > > > > -J > > > > > > Am Fr., 8. Feb. 2019 um 12:30 Uhr schrieb julio cesar sanchez > > <jcesarmob...@gmail.com>: > > > > > > Unless we find a way of enabling/disabling Android X support, it's going > > > to > > > be a breaking change for all plugins using using the old way, so we can't > > > do that in a 8.1 release > > > > > > El vie., 8 feb. 2019 a las 12:03, Jan Piotrowski (<piotrow...@gmail.com>) > > > escribió: > > > > > > > I am not sure I follow: > > > > Why are those blocking and can not be added with a quick 8.1 when > > > > those changes are merged? > > > > > > > > -J > > > > > > > > Am Fr., 8. Feb. 2019 um 01:55 Uhr schrieb Chris Brody < > > > > chris.br...@gmail.com>: > > > > > > > > > > I think the major blockers are AndroidX and bug 508. I already > > > > > proposed a quick fix solution for 508. For AndroidX I think we need to > > > > > do a little more analysis and testing. > > > > > > > > > > Unfortunately I cannot promise much on my part due to some other > > > > > priorities. I will try to take another look in the next few days, no > > > > > guarantees though. > > > > > > > > > > On Thu, Feb 7, 2019 at 2:22 PM Chris Brody <chris.br...@gmail.com> > > > > wrote: > > > > > > > > > > > > Update coming later today. I think there are still a number of > > > > > > blockers that we need to get resolved. > > > > > > > > > > > > On Thu, Feb 7, 2019 at 3:48 AM Bryan Ellis <ellis.br...@gmail.com> > > > > wrote: > > > > > > > > > > > > > > Can I get an update on this? > > > > > > > Is there anyone still working on any blockers that need to be > > > > finished > > > > > > > before release? > > > > > > > Can we continue with this release? > > > > > > > > > > > > > > > > > > > > > On Sat, Jan 19, 2019 at 6:49 AM Chris Brody > > > > > > > <chris.br...@gmail.com> > > > > wrote: > > > > > > > > > > > > > > > I would agree with Julio that we should verify androidx support > > > > before we > > > > > > > > finish the next major release. I don't expect we will have to > > > > > > > > make > > > > any > > > > > > > > fixes on cordova-android for androidx support. Issues for > > > > reference: > > > > > > > > * https://github.com/apache/cordova/issues/69 > > > > > > > > * https://github.com/apache/cordova-android/issues/565 > > > > > > > > > > > > > > > > I just raised WIP PR > > > > https://github.com/apache/cordova-android/pull/633 to > > > > > > > > resolve bug 508. I hope to fix the tests within the next 1-2 > > > > > > > > days. > > > > > > > > > > > > > > > > I think we should also try to resolve the following issues > > > > > > > > before > > > > the next > > > > > > > > major release: > > > > > > > > * https://github.com/apache/cordova-android/issues/629 - issue > > > > with > > > > > > > > Android > > > > > > > > Studio 3.2 & 3.3 > > > > > > > > * https://github.com/apache/cordova-android/issues/623 - fix > > > > logging of > > > > > > > > Java version (a PR was already proposed) > > > > > > > > > > > > > > > > I think it would be nice but not absolutely necessary to resolve > > > > the > > > > > > > > following issue as well: > > > > > > > > * https://github.com/apache/cordova-android/issues/617 - support > > > > > > > > ANDROID_SDK_ROOT in addition to ANDROID_HOME which is now > > > > deprecated > > > > > > > > * https://github.com/apache/cordova-android/issues/634 - update > > > > Gradle > > > > > > > > classpath for Android Studio 3.3 > > > > > > > > * review & merge the following PRs: > > > > > > > > - https://github.com/apache/cordova-android/pull/632 - ignore > > > > more > > > > > > > > Gradle > > > > > > > > build artifacts in Android project > > > > > > > > - https://github.com/apache/cordova-android/pull/635 - ignore > > > > Android > > > > > > > > Studio .idea files in Android project > > > > > > > > > > > > > > > > On Fri, Jan 18, 2019 at 9:09 AM julio cesar sanchez < > > > > > > > > jcesarmob...@gmail.com> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > As it's going to be a major release, I think we should look a > > > > bit more > > > > > > > > into > > > > > > > > > Android X before doing a major release, just in case we need > > > > > > > > > to > > > > do major > > > > > > > > > changes. > > > > > > > > > In the issue related to Android X, I commented that we didn't > > > > have the > > > > > > > > > gradle.properties file, but in the linked PR I saw it's going > > > > > > > > > to > > > > be > > > > > > > > > generated by the tooling now, so should be easier to just > > > > > > > > > write > > > > to it > > > > > > > > with > > > > > > > > > whatever is needed, and probably make it opt-in for now as > > > > > > > > > it's > > > > not clear > > > > > > > > > if using Android X will prevent old plugins from working. > > > > > > > > > Or is the gradle.properties file supposed to be managed by the > > > > user > > > > > > > > > somehow? > > > > > > > > > > > > > > > > > > El vie., 18 ene. 2019 a las 15:02, Chris Brody (< > > > > chris.br...@gmail.com>) > > > > > > > > > escribió: > > > > > > > > > > > > > > > > > > > I am investigating a quick solution for the bug, hope to > > > > > > > > > > have > > > > something > > > > > > > > > > today. > > > > > > > > > > > > > > > > > > > > On Fri, Jan 18, 2019, 8:42 AM Chris Brody < > > > > chris.br...@gmail.com > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > The bug was introduced by new code that was added to both > > > > master and > > > > > > > > > > 7.1.4. > > > > > > > > > > > > > > > > > > > > > > On 7.1.4 the issue is discussed in: > > > > > > > > > > > https://github.com/apache/cordova-android/issues/599 > > > > > > > > > > > > > > > > > > > > > > I hope we can find a quick solution before we make the new > > > > release. > > > > > > > > > > > > > > > > > > > > > > Fixing the bug would introduce some kind of change in > > > > behavior, with > > > > > > > > a > > > > > > > > > > > possible risk that it would be a breaking change for > > > > > > > > > > > someone > > > > else. > > > > > > > > > > > > > > > > > > > > > > On Fri, Jan 18, 2019 at 8:27 AM Jan Piotrowski < > > > > piotrow...@gmail.com > > > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > >> Is this a new bug introduced by the new code that would > > > > > > > > > > >> be > > > > released? > > > > > > > > > > >> If not, there is no reason to stop a release of that > > > > > > > > > > >> (good) > > > > code. As > > > > > > > > > > >> soon as a fix for this bug is available, we can release > > > > > > > > > > >> it > > > > as a > > > > > > > > follow > > > > > > > > > > >> up release (patch, minor, major - whatever appropriate). > > > > > > > > > > >> > > > > > > > > > > >> -J > > > > > > > > > > >> > > > > > > > > > > >> Am Fr., 18. Jan. 2019 um 13:18 Uhr schrieb Chris Brody < > > > > > > > > > > >> chris.br...@gmail.com>: > > > > > > > > > > >> > > > > > > > > > > > >> > I do not think we should make a new cordova-android > > > > release before > > > > > > > > > we > > > > > > > > > > >> can > > > > > > > > > > >> > resolve > > > > https://github.com/apache/cordova-android/issues/508 > > > > > > > > > > >> > > > > > > > > > > > >> > I think it is a pretty bad bug. I would be happy to > > > > explain > > > > > > > > further > > > > > > > > > if > > > > > > > > > > >> > needed. > > > > > > > > > > >> > > > > > > > > > > > >> > On Fri, Jan 18, 2019 at 12:56 AM Bryan Ellis < > > > > er...@apache.org> > > > > > > > > > > wrote: > > > > > > > > > > >> > > > > > > > > > > > >> > > Does anyone have any reason to delay a > > > > > > > > > > >> > > cordova-android > > > > platform > > > > > > > > > > >> release? > > > > > > > > > > >> > > Any outstanding patches to land? > > > > > > > > > > >> > > > > > > > > > > > > >> > > If not, I will start the release process shortly. > > > > > > > > > > >> > > > > > > > > > > > > >> > > > > > > > > > > >> > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > > > > > >> To unsubscribe, e-mail: > > > > > > > > > > >> dev-unsubscr...@cordova.apache.org > > > > > > > > > > >> For additional commands, e-mail: > > > > dev-h...@cordova.apache.org > > > > > > > > > > >> > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
